Feature/public and private states shared cache #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce) the public state root with the trie of private states root and each leaf in the trie of private states with the corresponding private state root
… provider for each option
…original code (the main private cache is created with the appropriate configuration)
|
|
nicolae-leonte-go
requested review from
baptiste-b-pegasys,
trung,
antonydenyer and
apratt3377
nicolae-leonte-go
requested review from
namtruong,
SatpalSandhu61,
antonydenyer and
chris-j-h
Krish1979
previously approved these changes
Mar 8, 2022
antonydenyer
previously approved these changes
Mar 8, 2022
nicolae-leonte-go
dismissed stale reviews from antonydenyer and Krish1979
via
19da1cc
Krish1979
approved these changes
Mar 8, 2022
achraf17
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the private state (or states in case of MPS) to behave similarly to the public state when it comes to what is written to the disk and how often.
Before this PR the private state is being flushed to the disk for each block (even though the corresponding public state is not - depending on the
--gcmodeparameter value).The behaviour is enabled by passing a command line parameter:
--privatetriecache.enableWhen enabled, the public and the private state(s) share the same
state.Databaseinstance. The single cache management (previously applying only to the public state) now also applies to the private state(s). TheTrieDB.Referencemechanism is used to link the various tries with each-other so that when aTrieDB.Commiton the public state root is issued it cascades to all other referenced tries (including the private states).When disabled (the parameter is missing from the command line) the private state(s) is still committed for each block with ONE NOTABLE DIFFERENCE: the order of commits is reversed - public state is committed first followed by the private state(s). The reason for the reversal is that when we commit the private state the public state root is already in the cache (which then allows us to add the reference from the private state root to the public state root).