Remove warn log when receiving pre-prepare msg for future block #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antonydenyer
approved these changes
Nov 30, 2021
baptiste-b-pegasys
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is perfectly normal for a node to eventually receive an istanbul pre-prepare for a future block. The code already handles this case and prints an INFO log msg to let the operator know that this msg will be dealt with later.
However, the code also ends up logging a WARN msg for this scenario. This can be misleading. We recently spent some time trying to understand what was going on only to realise it was an expected scenario.
This change prevents the WARN msg when we are dealing with a
ErrFutureBlocktype error.