Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract extension with mandatory recipients #1252

Merged
merged 16 commits into from
Sep 14, 2021
Merged

Contract extension with mandatory recipients #1252

merged 16 commits into from
Sep 14, 2021

Conversation

namtruong
Copy link
Contributor

@namtruong namtruong commented Sep 10, 2021 •
edited
Loading

  • Implement /transaction/{hash}/mandatorycall to Tessera to retrieve mandatory recipients data to be included in contract extension deployment
  • Update rpc call eth.getContractPrivacyMetadata to include mandatory recipients data in the json response - if transaction privacy type is MandatoryRecipients
  • Note that contract extension will preserve the mandatory recipients list and is not designed to add a new mandatory recipient

@namtruong
Add MandatoryRecipients data in SendRequest and SendSignedTxRequest t…
b66942e 
…o private TM
@namtruong
Update send and sendsignedtx method to include MandatoryRecipients, r…
ce91a8a 
…eject if PTM does not support correct version
@namtruong
Add new Tessera feature version - mandatoryRecipientsVersion
87a2c8d
@namtruong
Add PrivacyFlagMandatoryRecipients and new feature to support Mandato…
67e87c4 
…ryRecipients
@namtruong
Add mandatoryFor to PrivateTxArgs, validations and unit tests
265ceb7
@namtruong
Implement GetMandatory api call to Tessera
bf0e346
@namtruong
interface impl
97bf4c8
@namtruong
update mock generation
9281763
@namtruong
update mock generation
620d21a
@namtruong
Cater for mandatory recipients data when extending contract
5be3210
@namtruong
api to retrieve privacymetadata - also include mandatory recipients f…
5aecac6 
…or relevant flag type
@namtruong
Merge branch 'master' of https://github.com/ConsenSys/quorum into con…
8409a77 
…tract-extenstion-with-mandatory-recipients

� Conflicts:
�	internal/ethapi/api_test.go
@namtruong
unit tests
835cc75
@namtruong
fix lint check
00f4e1a
@namtruong namtruong changed the title Contract extenstion with mandatory recipients Contract extension with mandatory recipients Sep 10, 2021
@namtruong namtruong closed this Sep 10, 2021
@namtruong namtruong reopened this Sep 10, 2021
nicolae-leonte-go
nicolae-leonte-go approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@nicolae-leonte-go nicolae-leonte-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardolyn ricardolyn merged commit c6bce64 into Consensys:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardolyn ricardolyn ricardolyn approved these changes

@nicolae-leonte-go nicolae-leonte-go nicolae-leonte-go approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@namtruong @ricardolyn @nicolae-leonte-go @Krish1979