Protect ProposerPolicy Registry using Mutex #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght have triggered before calling Seal()
danielporto
pushed a commit
to danielporto/quorum
that referenced
this pull request
Sep 7, 2021
* Protect access to validator set in ProposerPolicy using mutex * Making Registry private * Moving eventLoop() to after calling Seal() as earlier stop channel might have triggered before calling Seal()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegisterValidatorSet()might throw a nil pointer, if thevalidatorSetregistry is cleared inClearRegistry()by another goroutine. To fix this access toregistryneeds to be protected.