This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Change core config format to include explicit node blocks. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* qubernetes qubernetes.yaml works with nodes inside qubernetes.yaml. * fixed quorum generation to work with new node format, notes genesis may have different consensus and chainId than the nodes, this is supported for now, as that may be a true reflection of the network, but this would be an incorrect network.. * remove permission-nodes.json.tmpl and script, as now it will be updated with the hostnames when nodes are added. Use sym links to link the file to the permissioned-nodes configMap dir, this is necessary, because only configMaps mounted as directories will be updated without a redeploy.
Since the core configuration file no long support a simple number for the number of nodes, but includes a node element add a quick-start-gen to make getting started as easy as possible. * Add a quick-start-gen which can generate a full config give a number of nodes, consensus, and versions. * Update quickest-start.sh so that it works with the quick-start-gen, as updating the number of nodes in the core config is no longer supported.
* Add back support for existing config file, base key dir, etc. * Update 7nodes core config to new format. * Regenerate 7nodes examples: istanbul/constellation, istanbul/tessera, raft/constellation, raft/tessera.
* Now that hostnames are used, do not need variable / logs for extracting IPs. * Most variables are not set in the qubernetes file before calling the templates. * Add support for custom docker repo. * Fix tessera configs, make sure to update the config with the current running host.
* Updated and tested all the config to make sure they follow the new format. * Rename example/configs to shorter names, leave off qubernetes prefix.
* also fix shared config k8s as istanbul-validator.toml will not be present for raft.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of nodes.yaml and the simple specifying of number of node in the core config. Having a simple way to specify the number of nodes, is good for easy of use, but is not a good design for keeping the core config as a representation of the running state, and thus makes updating and day two ops tricky. The new config require that the node blocks are explicitly included in the core config. There is a helper script for quick start
quick-start-genthat can generate a base core config given the number of desired nodes and other optional paramsquick-start-gen --helpthe quickest-start.sh uses this, and works the same as before.