Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add support geth websockets rcp. #28

Merged
merged 2 commits into from
May 1, 2020

Conversation

libby
Copy link
Contributor

@libby libby commented May 1, 2020

Add support for connecting to geth via websockets rpc. The default port is set to 8546 and will always be set, but in order to use websockets they need to be enabled in the geth.Geth_Startup_Param inside the config yaml, e.g. --ws --wsorigins="*" --wsaddr 0.0.0.0 see examples/config/qubernetes-ingress-ws.yaml

To override the default set it in the config under geth.Node_WSPort.

note:
If trying to connect externally via an ingress be aware that depending on the backend k8s service and how the load balancing is implemented the health checks may fail, e.g. for GKE currently has a health check that uses http, and setting a configurable health check in k8s is not supported yet,
but will be available soon: kubernetes/ingress-gce#1067.

Add support for connecting to geth via websockets. The default port is
set to 8546 and will always be set, but websockets need to be enabled in
the Geth_Startup_Param inside the config, e.g. --ws --wsorigins=\"*\" --wsaddr 0.0.0.0
see examples/config/qubernetes-ingress-ws.yaml

To override the default set it in the config unger `geth.Node_WSPort`.

note:
If trying to connect externally from an ingress be aware that depending
on the backend k8s service and how the load balancing is implenented the
health checks may fail, e.g. for GKE setting a configurable health check in k8s is not supported yet,
but will be available soon: kubernetes/ingress-gce#1067.
@libby libby requested a review from jbhurat May 1, 2020 21:02
Copy link
Contributor

@jbhurat jbhurat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

change the 7nodes examples configs RPCPort to the default geth rpc port
so that it doesn't clash with the default websocket port (8546).
@libby libby merged commit 869a992 into Consensys:master May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants