Skip to content

fix: handle OR call for constant inputs #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2025
Merged

fix: handle OR call for constant inputs #1592

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bec541
fix: handle OR call for constant inputs
ivokub Aug 29, 2025
75c450f
chore: use stored cnst instead of ints
ivokub Sep 2, 2025
a4c3a11
chore: return constant LE
ivokub Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions frontend/cs/r1cs/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,31 @@ func (builder *builder[E]) Or(_a, _b frontend.Variable) frontend.Variable {
builder.AssertIsBoolean(a)
builder.AssertIsBoolean(b)

_aC, aConstant := builder.constantValue(a)
_bC, bConstant := builder.constantValue(b)

if aConstant && bConstant {
if builder.cs.IsOne(_aC) || builder.cs.IsOne(_bC) {
return builder.cstOne()
}
return builder.cstZero()
}

// if one input is constant, ensure we put it in b
if aConstant {
a, b = b, a
_bC = _aC
bConstant = aConstant
}

if bConstant {
if builder.cs.IsOne(_bC) {
return 1
} else {
return a
}
}

// the formulation used is for easing up the conversion to sparse r1cs
res := builder.newInternalVariable()
builder.MarkBoolean(res)
Expand Down
Loading