feat: add BN254 final exponentiation check with output#1209
Merged
Conversation
9 tasks
yelhousni
approved these changes
Jul 23, 2024
Contributor
yelhousni
left a comment
There was a problem hiding this comment.
LGTM! just made same renaming suggestions.
Collaborator
Author
|
Applied the review suggestions + added documentation for |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some cases we are interested to obtain the value if the final exponentiation resulted in 1 or not instead of asserting. Refactor and add such method.
With this, also renamed
FinalExpChecktoAssertFinalExpCheckto better distinguish different methods.Type of change
How has this been tested?
Checklist:
golangci-lintdoes not output errors locally