feat/hashregistry#687
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a registry for hash functions, enabling lookup by string name and registration of custom hash functions for testing purposes. Key changes include:
- Introducing a new map (hashesByName) and helper functions (findStdHashByName, RegisterCustomHash) in hash/hashes.go.
- Updating the NewHash function to support both standard and custom hash functions.
- Optimizing the string handling in ecc/ecc.go by lowercasing the input once.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hash/hashes.go | Added hash registry functionality and helper functions for standard/custom hashes. |
| ecc/ecc.go | Adjusted IDFromString to lowercase the input string outside the loop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the ability to look up hashes by string name, and also to register custom functions for testing purposes.