Skip to content

refactor(bls12-381, bls12-377): MillerLoopFixed corresponds to gnark#524

Merged
yelhousni merged 1 commit intomasterfrom
refactor/bls12-MillerLoopFixed
Sep 3, 2024
Merged

refactor(bls12-381, bls12-377): MillerLoopFixed corresponds to gnark#524
yelhousni merged 1 commit intomasterfrom
refactor/bls12-MillerLoopFixed

Conversation

@yelhousni
Copy link
Copy Markdown
Collaborator

Description

Similar to #506 for BLS12-377 and BLS12-381.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Existing tests pass.

+ [BLS12-*] Pair should output the same result with MillerLoop or MillerLoopFixedQ: OK, passed 100 tests.

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

Lines precomputations should be faster, but this is a one-time computation.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: consolidate strengthen an existing feature type: perf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants