Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about emptyBlockPeriodSeconds #246

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

antonydenyer
Copy link
Contributor

@antonydenyer antonydenyer commented Aug 2, 2022

Describe the change

Add basic documentation about how to configure empty block period implemented in Consensys/quorum#1433

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 11:42 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 11:47 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 11:53 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 11:53 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 11:56 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 11:58 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 2, 2022 12:01 Inactive
@antonydenyer antonydenyer marked this pull request as ready for review August 2, 2022 12:53
@antonydenyer antonydenyer requested a review from a team as a code owner August 2, 2022 12:53
@rolandtyler rolandtyler temporarily deployed to preview August 2, 2022 17:23 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits. I also moved the section up so it was just after setting the blockPeriodSeconds since they're related. LGTM

@antonydenyer antonydenyer temporarily deployed to preview August 4, 2022 11:25 Inactive
@antonydenyer antonydenyer temporarily deployed to preview August 4, 2022 11:27 Inactive
@antonydenyer antonydenyer merged commit 6577d8e into Consensys:main Aug 4, 2022
@antonydenyer antonydenyer deleted the feat/empty-blocks branch August 4, 2022 11:39
@antonydenyer antonydenyer temporarily deployed to no-secret August 4, 2022 11:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants