Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .env.template #222

Merged
merged 2 commits into from
May 17, 2022
Merged

remove .env.template #222

merged 2 commits into from
May 17, 2022

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented May 10, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Remove .env.template and update docker-compose.yml.

Issue fixed

fixes #221

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@alexandratran alexandratran requested a review from a team as a code owner May 10, 2022 19:44
@alexandratran alexandratran temporarily deployed to preview May 10, 2022 19:44 Inactive
@alexandratran alexandratran temporarily deployed to no-secret May 10, 2022 19:44 Inactive
@alexandratran alexandratran temporarily deployed to no-secret May 10, 2022 19:44 Inactive
@alexandratran alexandratran temporarily deployed to no-secret May 16, 2022 17:32 Inactive
@alexandratran alexandratran temporarily deployed to no-secret May 16, 2022 17:32 Inactive
@alexandratran alexandratran temporarily deployed to preview May 16, 2022 17:32 Inactive
@alexandratran alexandratran temporarily deployed to no-secret May 16, 2022 17:32 Inactive
@alexandratran alexandratran temporarily deployed to no-secret May 16, 2022 17:32 Inactive
Copy link
Member

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alexandratran alexandratran merged commit d47635b into main May 17, 2022
@alexandratran alexandratran deleted the 221-env-file branch May 17, 2022 17:07
@alexandratran alexandratran temporarily deployed to no-secret May 17, 2022 17:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove env variable file
2 participants