Add all networking reference tests. Some are ignored because test fixtures are broken - #10677
Merged
zilm13 merged 2 commits intoMay 7, 2026
Merged
Conversation
| // fixed; the block in the fixture is not correctly built over the payload. | ||
| .put( | ||
| "fork_choice/on_execution_payload_envelope", | ||
| new ForkChoiceTestExecutor("on_execution_payload_envelope__valid")) |
Contributor
There was a problem hiding this comment.
I like this, skip, didn't know we can do that, can we change comment to TODO-GLOAS just to be consistent
Contributor
Author
There was a problem hiding this comment.
updated in cb402b8
networking tests are all milestones broken so it's not related to them but i grouped all ignored, because it all applies to the same issue
zilm13
force-pushed
the
devnet-2-networking-tests
branch
from
May 7, 2026 17:46
cb402b8 to
f6dd69a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit f6dd69a. Configure here.
| // block being signed (beacon_block_root) matches the local head as selected by fork | ||
| // choice (this requires maintaining a cache of size `SYNC_COMMITTEE_SIZE // | ||
| // SYNC_COMMITTEE_SUBNET_COUNT` for each subnet that can be flushed after each slot). | ||
| // [IGNORE] There has been no other valid sync committee message for the declared slot for |
Contributor
There was a problem hiding this comment.
Specs changed for this check specifically?
Contributor
Author
There was a problem hiding this comment.
StefanBratanov
approved these changes
May 7, 2026
StefanBratanov
left a comment
StefanBratanov
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Added executors for:
Ignored tests are relied on ethereum/consensus-specs#5201, they will work after it's resolved, merged and released (alpha.8, probably)
Also
SyncCommitteeMessageValidatorwas fixed, check current spec for confirmation.Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Adds multiple new reference-test executors and changes
SyncCommitteeMessageValidatorduplicate-detection semantics, which can affect gossip acceptance/ignore behavior and test coverage across forks.Overview
Adds new networking reference-test executors for
gossip_sync_committee_message,gossip_sync_committee_contribution_and_proof, andgossip_bls_to_execution_change, plus a dedicated executor forgossip_beacon_aggregate_and_proof(still wired as ignored due to broken fixtures). UpdatesGossipTeststo enable the sync-committee executors while leaving other gossip types ignored.Introduces
TestDataUtils.createAnchorFromStateand switches gossip executors to use it, avoidingAnchorPointgenesis body-root checks that break for some forks (e.g. Gloas). Adjusts fork-choice reference tests to skip only the known-badon_execution_payload_envelope__validcase and relaxes Gloas test filtering inReferenceTestFinder.Updates
SyncCommitteeMessageValidatorto treat duplicates as unique per(slot, validator_index, subnet)(removing the prior “replace if matches local head” behavior based onbeacon_block_root). Also addsinfrastructure:timetest fixtures to the reference-test Gradle dependencies.Reviewed by Cursor Bugbot for commit 569b98a. Bugbot is set up for automated code reviews on this repo. Configure here.