This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Use effectiveGasPrice and fall back to gasPrice when missing.#4600
Closed
its-everdred wants to merge 4 commits intodevelopfrom
Closed
Use effectiveGasPrice and fall back to gasPrice when missing.#4600its-everdred wants to merge 4 commits intodevelopfrom
its-everdred wants to merge 4 commits intodevelopfrom
Conversation
its-everdred
force-pushed
the
fix-arbitrum-gas-paid-4559
branch
from
ca79178 to
c951c1c
Compare
its-everdred
force-pushed
the
fix-arbitrum-gas-paid-4559
branch
from
c951c1c to
73e6269
Compare
Contributor
|
Hi @kevinweaver! Asking you as an open source contributor at large :) Do you know what happened to this PR? Should it be closed, or did this get resolved with the new version of Arbitrum? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In, #4559 we noticed that truffle was displaying incorrect transaction fees when using Arbitrum. This has to do with complexity that exists for their L2 that makes
transaction.gasPriceunreliable compared toreceipt.effectiveGasPrice. However, this isn't a problem that we need Arbitrum-specific code to support becausegasPricehas been officially deprecated in favor ofeffectiveGasPricepost-EIP-1559 anyway.Solution
When reporting transactions fees, set the gas price to
receipt.effectiveGasFeeif it exists, otherwisetransaction.gasPriceTo do
Check that this works on different versions of ganache, EIP-1559 & legacy transactions, Arbitrum & Ethereum.