Fix GetSettings - Ignore nameless values & trim values. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

CharlesNRU wants to merge 2 commits into ConfigJon:master from CharlesNRU:master

CharlesNRU commented Nov 3, 2020

Hello,

2 things in this pull request:

On some models, GetSettings would return a bunch of BIOS settings which have a name value of a space character. So I filter those out.
When trying to identify the setting, sometimes there is a space at the beginning of the value so it cannot identify correctly the current value so I added a Trim() to the value to remove the extra spaces.

CharlesNRU added 2 commits

November 2, 2020 20:44


          Fix GetSettings - Ignore nameless values & trim values.

dee5039


          Trimming values when getting current values

3331a04

Author

CharlesNRU commented Nov 5, 2020

Added a commit because I found a similar issue with getting current values before setting BIOS settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet