Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate connector yaml #180

Merged
merged 27 commits into from
Feb 4, 2025
Merged

Generate connector yaml #180

merged 27 commits into from
Feb 4, 2025

Conversation

lovromazgon
Copy link
Member

Description

This is the first connector to use specgen and showcases its usage. The changes that were done are explained in detail in this PR: ConduitIO/conduit-connector-sdk#198

One more thing that was changes in this PR unrelated to specgen is the removal of the deprecated topic parameter in favor of topics, which was marked as required now.

Depends on ConduitIO/conduit-connector-sdk#198 and ConduitIO/conduit-commons#131.

Related to ConduitIO/conduit#1523.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso mentioned this pull request Jan 6, 2025
Closed
7 tasks
@hariso
Squashed commit of the following:
73302ec 
commit ad0ea55
Author: Haris Osmanagic <[email protected]>
Date:   Tue Feb 4 10:55:37 2025 +0100

    add ctx to validate

commit 87e0ba0
Author: Haris Osmanagic <[email protected]>
Date:   Tue Feb 4 10:53:06 2025 +0100

    test

commit b99b843
Author: Haris Osmanagic <[email protected]>
Date:   Tue Feb 4 10:29:15 2025 +0100

    fix validation

commit 2d14859
Author: Haris Osmanagic <[email protected]>
Date:   Tue Feb 4 10:19:14 2025 +0100

    check for empty string

commit 2c2741e
Author: Haris Osmanagic <[email protected]>
Date:   Mon Feb 3 20:50:35 2025 +0100

    readme

commit de7dc03
Author: Haris Osmanagic <[email protected]>
Date:   Mon Feb 3 20:44:03 2025 +0100

    Generate connector.yaml

commit 130e372
Author: Lovro Mažgon <[email protected]>
Date:   Wed Jan 29 13:37:57 2025 +0100

    Move scarf pixel to the bottom of the readme (#191)

    Co-authored-by: Haris Osmanagić <[email protected]>

commit 5884082
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jan 29 12:27:20 2025 +0000

    .github: Bump dependabot/fetch-metadata from 2.2.0 to 2.3.0 (#194)

    Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 2.2.0 to 2.3.0.
    - [Release notes](https://github.com/dependabot/fetch-metadata/releases)
    - [Commits](dependabot/fetch-metadata@v2.2.0...v2.3.0)

    ---
    updated-dependencies:
    - dependency-name: dependabot/fetch-metadata
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 0b92cad
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jan 28 17:01:50 2025 +0000

    go.mod: bump github.com/goccy/go-json from 0.10.4 to 0.10.5 (#195)

    Bumps [github.com/goccy/go-json](https://github.com/goccy/go-json) from 0.10.4 to 0.10.5.
    - [Release notes](https://github.com/goccy/go-json/releases)
    - [Changelog](https://github.com/goccy/go-json/blob/master/CHANGELOG.md)
    - [Commits](goccy/go-json@v0.10.4...v0.10.5)

    ---
    updated-dependencies:
    - dependency-name: github.com/goccy/go-json
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a3d4411
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jan 21 16:28:38 2025 +0000

    go.mod: bump github.com/twmb/franz-go/pkg/kadm from 1.14.0 to 1.15.0 (#193)

    Bumps [github.com/twmb/franz-go/pkg/kadm](https://github.com/twmb/franz-go) from 1.14.0 to 1.15.0.
    - [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
    - [Commits](twmb/franz-go@v1.14.0...v1.15.0)

    ---
    updated-dependencies:
    - dependency-name: github.com/twmb/franz-go/pkg/kadm
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit c1d3fe6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jan 21 16:25:17 2025 +0000

    go.mod: bump github.com/twmb/franz-go from 1.18.0 to 1.18.1 (#192)

    Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.18.0 to 1.18.1.
    - [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
    - [Commits](twmb/franz-go@v1.18.0...v1.18.1)

    ---
    updated-dependencies:
    - dependency-name: github.com/twmb/franz-go
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 41bef8f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jan 6 16:12:16 2025 +0000

    go.mod: bump github.com/golangci/golangci-lint from 1.63.3 to 1.63.4 (#190)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.3 to 1.63.4.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.63.3...v1.63.4)

    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1ebe5a2
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jan 3 16:25:26 2025 +0000

    go.mod: bump github.com/golangci/golangci-lint from 1.63.2 to 1.63.3 (#189)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.2 to 1.63.3.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.63.2...v1.63.3)

    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit f26ddfd
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Jan 2 16:42:33 2025 +0000

    go.mod: bump github.com/golangci/golangci-lint from 1.63.0 to 1.63.2 (#188)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.63.0 to 1.63.2.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.63.0...v1.63.2)

    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4c1cbd0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jan 1 16:28:56 2025 +0000

    go.mod: bump github.com/golangci/golangci-lint from 1.62.2 to 1.63.0 (#187)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.62.2 to 1.63.0.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.62.2...v1.63.0)

    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@hariso hariso mentioned this pull request Feb 4, 2025
Closed
4 tasks
@hariso hariso marked this pull request as ready for review February 4, 2025 10:11
@hariso hariso requested a review from a team as a code owner February 4, 2025 10:11
raulb
raulb approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the topic removal to make topics required now 👍

@hariso hariso merged commit 42c3104 into main Feb 4, 2025
4 checks passed
@hariso hariso deleted the lovro/connector-yaml branch February 4, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso left review comments

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovromazgon @raulb @hariso