Add user login support to SDK #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ffb94ba.
jirwin
reviewed
Oct 10, 2023
pkg/types/resource/user_trait.go
Outdated
| @@ -34,6 +34,22 @@ func WithEmail(email string, primary bool) UserTraitOption { | |||
| return nil | |||
| } | |||
| } | |||
| func WithUsername(username string, primary bool) UserTraitOption { | |||
There was a problem hiding this comment.
I'm not sure Username is the right name for this field. If it is, this option should probably be renamed to WithUserUsername() since it is an option specific to user traits.
maybe external_identifier ?
jirwin
reviewed
Oct 10, 2023
| // Indicates if this is the user's primary username. Only one entry can be marked as primary. | ||
| bool is_primary = 2; | ||
| } | ||
| repeated Username usernames = 6; |
There was a problem hiding this comment.
nit: can this go to the bottom so it is easier for the next person to know the next field number?
loganintech
changed the title
jirwin
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.