-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default decoder limits to allow baton to list resources with big c1zs. #210
Conversation
… big c1zs. Also print the env vars that are needed to change the limits.
WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pkg/dotc1z/decoder.go (2 hunks)
Additional comments not posted (4)
pkg/dotc1z/decoder.go (4)
17-17
: Increase indefaultMaxDecodedSize
is appropriate.The increase from 2 GiB to 3 GiB aligns with the PR objectives to handle larger datasets. Ensure that this change does not affect other parts of the system that might depend on the previous limit.
18-18
: Increase indefaultDecoderMaxMemory
is appropriate.The increase from 32 MiB to 128 MiB supports enhanced memory allocation for decoding operations. Ensure that this change does not affect other parts of the system that might depend on the previous limit.
27-27
: Updated error message forErrMaxSizeExceeded
improves usability.Including instructions for using the
BATON_DECODER_MAX_DECODED_SIZE_MB
environment variable enhances clarity for users. Ensure this variable is documented for user reference.
28-28
: Updated error message forErrWindowSizeExceeded
improves usability.Including instructions for using the
BATON_DECODER_MAX_MEMORY_MB
environment variable enhances clarity for users. Ensure this variable is documented for user reference.
Also print the env vars that are needed to change the limits.
Summary by CodeRabbit
New Features
Improvements