Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotator #45

Open
eatnumber1 opened this issue Jul 6, 2013 · 0 comments
Open

Rotator #45

eatnumber1 opened this issue Jul 6, 2013 · 0 comments
Labels
enhancement

Comments

@eatnumber1
Copy link
Member

Implement ye olde rotator
cgonyeo pushed a commit to cgonyeo/bingehack4 that referenced this issue Aug 26, 2015
@tung
Fix log deviation when restoring on certain turns
ee993ce 
Without this, restoring a game on a turn divisible by 15 advances RNG
state without taking a turn, due to a check for automatic clairvoyance
(also may change level memory in zero turns, noted on the NetHack wiki,
so this bug also exists in vanilla NetHack).

Similarly, restoring a game on a turn divisible by 100 may change game
state due to real-time effects in zero turns, e.g. full moon or Friday
the 13th, potentially causing log replay deviation of its own.  For
time-related messages to still be shown when restoring a game, they had
to be split out into their own function.

This bug also exists in upstream NitroHack.

Fixes ComputerScienceHouse#45 on [DynaHack's tracker].

(cherry picked from commit 74ec0f19f568e14acf9c57763ae88d76c0b886fb)

Conflicts:
	libnitrohack/src/allmain.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eatnumber1