docs: update links to slack_bot_agent/adding_slack_bot.gif
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 78b5f6e in 10 seconds
More details
- Looked at
139lines of code in10files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. python/examples/advanced_agents/slack_bot_agent/slack_agent_autogen/readme.md:6
- Draft comment:
Consider updating the image link to point to the master branch for consistency:
This comment applies to similar links in other README files as well.
- Reason this comment was not posted:
Confidence changes required:50%
The PR updates links to a GIF in multiple README files. The new links point to the correct location in the master branch, which is a valid update. However, there are other image links in the same files that still point to the 'feat/slack-assistant' branch. These should also be updated for consistency.
Workflow ID: wflow_tEjO8La6sNoFEIbs
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please note that the fix was partially done in #718, but it introduced some typos (i.e. @sohamganatra: is there anything else I should do regarding this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates links to
slack_bot_agent/adding_slack_bot.gif(thefeat/slack-assistantbranch does not exist anymore).I would also recommend to use relative paths: what is the reason that you used absolute ones?
`
Important
Update links to
slack_bot_agent/adding_slack_bot.gifin multiple README files to point to the master branch.slack_bot_agent/adding_slack_bot.gifincrewai/readme.md,llamaindex/readme.md, andslack_agent_autogen/readme.md.slack_agent_crewai/readme.md,slack_agent_langchain/readme.md, andslack_agent_llamaindex/readme.md.slack_agent_ollama/readme.mdandslack_agent_openai/readme.md.This description was created by
for 78b5f6e. It will automatically update as commits are pushed.