Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add custom github auth using metadata #1109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreysingla11
Copy link
Collaborator

@shreysingla11 shreysingla11 commented Dec 30, 2024

Important

Add custom GitHub authentication using metadata in git_clone_cmd and GitClone.execute.

  • Behavior:
    • git_clone_cmd now requires github_access_token as a parameter instead of fetching from environment.
    • execute method in GitClone retrieves github_access_token from metadata if not in environment.
  • Error Handling:
    • Raises RuntimeError in git_clone_cmd if no token is provided and ALLOW_CLONE_WITHOUT_REPO is not "true".

This description was created by Ellipsis for 7e4994b. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 1:46pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7e4994b in 11 seconds

More details
  • Looked at 35 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/tools/local/filetool/actions/git_clone.py:31
  • Draft comment:
    Consider handling the logic for checking the presence of github_access_token in the execute method to avoid duplication.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The github_access_token is being retrieved from the environment variables and metadata, but the logic for checking its presence is duplicated in git_clone_cmd. It would be more efficient to handle this logic once in the execute method.

Workflow ID: wflow_ltz4nGhTvugr8qcO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant