solana-ed25519: move ED25519 Solana verification code into a new crate #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly because we are going to be patching ibc-rs to support Solana signature verefication and to avoid circular dependencies we need the ED25519 code in a separate crate that solana-ibc and ibc-rs can both depend on.
blasrodri
approved these changes
Feb 6, 2024
|
tkaitchuck/aHash#200 is the clippy failure |
|
sighs ahash 0.8.6 doesn’t compile on nightly and ahash 0.8.7 doesn’t compile with Anchor’s version of rustc. |
This reverts commit 1d9669d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly because we are going to be patching ibc-rs to support
Solana signature verefication and to avoid circular dependencies we
need the ED25519 code in a separate crate that solana-ibc and ibc-rs
can both depend on.