-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve InputType for controls #75
Conversation
@kasperpeulen Will check! 👀 |
One week later, whats the state? |
Can I help here? Why is this still blocked from merging? Looks like someone needs to make a review approval 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @Shinigami92 for the contribution and for your patience getting it merged! The change is good and I tightened up the types with a discriminated union.
@shilman looks like the formatting is broken and also the release failed. Could you please fix this so the release can run? |
Argh. Will get it fixed. Thanks! |
The types are released in |
🚀 PR was released in |
@Shinigami92 Will try to get this new version into |
@Shinigami92 Working on releasing it, but first I have loosened the type a bit here: |
No description provided.