Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reg error in 10-bash.jinjia #12775

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

xcfxr
Copy link
Contributor

@xcfxr xcfxr commented Jan 3, 2025

sed -i use Basic Regular Expression(BRE), so it needs to use Escape character when using character like ')', '?', '+' and so on. I see it may be forgot here. There is another question here. After modifying /etc/default/grub, grub2-mkconfig is not used to make it effective, so the modification is meaningless. Should I directly modify /etc/grub2.cfg (x86) or /etc/grub2-efi/cfg?

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 3, 2025
Copy link

openshift-ci bot commented Jan 3, 2025

Hi @xcfxr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 3, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 7, 2025

Code Climate has analyzed commit 2bca4f3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.76 milestone Jan 8, 2025
@vojtapolasek vojtapolasek self-assigned this Jan 10, 2025
@vojtapolasek
Copy link
Collaborator

@xcfxr the PR looks good. Regarding your question, what product are you concerned about?
The macro you modify is then used at line 1955. And it is closely followed by

{{{ grub_command("remove", arg_name) }}}

So this should solve the propagation of the removal to grub.cfg or whatever Grub configuration format is used. Do you agree?

Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vojtapolasek vojtapolasek merged commit af4b1c4 into ComplianceAsCode:master Jan 14, 2025
95 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants