Flush automatus test logs before outputting results #11605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that logs contain all the test stdout/stderr outputs at the moment of automatus.py announcing their results on its output. This is useful for an external automatus.py wrapper, which parses its output in real-time, while also processing the logs in real-time. The flushing is done here and not deeper, because it seems unnecessary to flush after every 'retry' attempt, only when the test is done running and its result is about to be announced by automatus.py. Signed-off-by: Jiri Jaburek <[email protected]>
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 6c3102e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This ensures that logs contain all the test stdout/stderr outputs at the moment of automatus.py announcing their results on its output.
The flushing is done here and not deeper, because it seems unnecessary to flush after every 'retry' attempt, only when the test is done running and its result is about to be announced by automatus.py.
Rationale:
This is useful for an external automatus.py wrapper, which parses its output in real-time, while also processing the logs in real-time. Without this change, the wrapper will get empty logs in some cases.