-
Notifications
You must be signed in to change notification settings - Fork 736
Add automation to enable faillock rules #11458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation to enable faillock rules #11458
Conversation
Hi @Xeicker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew data stream adds OVAL for rule 'xccdf_org.ssgproject.content_rule_account_password_pam_faillock_password_auth'.
New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_account_password_pam_faillock_password_auth'.
New data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_account_password_pam_faillock_password_auth'.
New data stream adds OVAL for rule 'xccdf_org.ssgproject.content_rule_account_password_pam_faillock_system_auth'.
New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_account_password_pam_faillock_system_auth'.
New data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_account_password_pam_faillock_system_auth'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good contribution. We only need to extend the OVAL to more precisely assess the pam_faillock implementation.
...am/locking_out_password_attempts/account_password_pam_faillock_password_auth/oval/shared.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the OVAL extension @Xeicker . The rules are working fine. There is a conflict to be solved before we can merge it. So I would ask you to also review the indentation used in OVAL, please. Its minor stuff but would be good to take a look since you need to resolve the conflict anyway.
...-pam/locking_out_password_attempts/account_password_pam_faillock_system_auth/oval/shared.xml
Show resolved
Hide resolved
...-pam/locking_out_password_attempts/account_password_pam_faillock_system_auth/oval/shared.xml
Outdated
Show resolved
Hide resolved
Add OVAL, bash and ansible to account_password_pam_faillock_system_auth & account_password_pam_faillock_password_auth Signed-off-by: Edgar Aguilar <[email protected]>
Add rules account_password_pam_faillock_system_auth & account_password_pam_faillock_password_auth to Ol8 STIG profile, and assign the mentioned STIG ids as references Signed-off-by: Edgar Aguilar <[email protected]>
Rules account_password_pam_faillock_system_auth & account_password_pam_faillock_password_auth Signed-off-by: Edgar Aguilar <[email protected]>
account_password_pam_faillock_system_auth & account_password_pam_faillock_password_auth missed this info Signed-off-by: Edgar Aguilar <[email protected]>
The rules account_password_pam_faillock_system_auth & account_password_pam_faillock_password_auth need to check more items to be considered pass Signed-off-by: Edgar Aguilar <[email protected]>
6625a93
to
98ae33d
Compare
account_password_pam_faillock_system_auth & account_password_pam_faillock_password_auth Signed-off-by: Edgar Aguilar <[email protected]>
Code Climate has analyzed commit fd0e6ef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Xeicker
Overriding CODEOWNERS since a Oracle maintainer is not currently available. |
Description:
account_password_pam_faillock_system_auth
&
account_password_pam_faillock_password_auth
Rationale: