Remove warning from kubelet rule

[montaguethomas]

Description:

#10464 did a major refactor of the kubelet rules to move them from running as "Platform" checkType to "Node". This rule was missed to remove the warnings flag, as this causes CO to consider the rule as a Platform checkType.

CO Rule parsing logic:

• https://github.com/ComplianceAsCode/compliance-operator/blob/6bcc5d5d8853885eeec4cf41e7861e467a57eece/pkg/profileparser/profileparser.go#L686-L693
• https://github.com/ComplianceAsCode/compliance-operator/blob/6bcc5d5d8853885eeec4cf41e7861e467a57eece/pkg/utils/parse_arf_result.go#L646-L647C40

Rationale:

While trying to tailor out the rule in Compliance Operator, it's impossible to do so as the rule is run as a Node scan but is imported as a Platform checkType.

[openshift-ci]

Hi @montaguethomas. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[Vincent056]

that's a good catch, thanks for fixing it!

[Vincent056]

/ok-to-test

[Vincent056]

/test

[openshift-ci]

@Vincent056: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test e2e-aws-ocp4-cis
• /test e2e-aws-ocp4-cis-node
• /test e2e-aws-ocp4-e8
• /test e2e-aws-ocp4-high
• /test e2e-aws-ocp4-high-node
• /test e2e-aws-ocp4-moderate
• /test e2e-aws-ocp4-moderate-node
• /test e2e-aws-ocp4-pci-dss
• /test e2e-aws-ocp4-pci-dss-node
• /test e2e-aws-ocp4-stig
• /test e2e-aws-ocp4-stig-node
• /test e2e-aws-rhcos4-e8
• /test e2e-aws-rhcos4-high
• /test e2e-aws-rhcos4-moderate
• /test e2e-aws-rhcos4-stig
• /test images

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-ComplianceAsCode-content-master-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Vincent056]

/test e2e-aws-ocp4-high
/test e2e-aws-ocp4-high-node

[openshift-ci]

@montaguethomas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ocp4-high-node	8705fe9	link	true	/test e2e-aws-ocp4-high-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[yuumasato]

@montaguethomas Hi, thanks for the patch.

Could you rebase on top of latest master?
There is a new required test that needs to be run, this will also re-trigger the prow test, that apparently failed to setup.

[Vincent056]

/lgtm

[codeclimate]

Code Climate has analyzed commit 5b7260e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

[xiaojiey]

verification passed.

Without the PR, the node type is Platform
$ oc get rule ocp4-kubelet-configure-tls-min-version -o=jsonpath={.checkType}
Platform
With the PR, the node type is Node:
$ oc get rule upstream-ocp4-kubelet-configure-tls-min-version -o=jsonpath={.checkType}
Node
$ oc get ccr | grep kubelet-configure-tls-min-version
upstream-ocp4-high-node-master-kubelet-configure-tls-min-version                        PASS     medium
upstream-ocp4-high-node-worker-kubelet-configure-tls-min-version                        PASS     medium