Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new OnPropertyNameChanging and Changed overloads #582

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Add new OnPropertyNameChanging and Changed overloads #582

merged 7 commits into from
Jan 31, 2023

Conversation

Sergio0694
Copy link
Member

Closes #575

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Jan 22, 2023
@Sergio0694
Copy link
Member Author

@Youssef1313 feel free to also have a quick look here if you feel like it 😄

@Sergio0694 Sergio0694 force-pushed the dev/new-property-hooks branch 2 times, most recently from c205356 to 8a8d4b8 Compare January 31, 2023 23:06
@Sergio0694 Sergio0694 merged commit 01efc75 into main Jan 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/new-property-hooks branch January 31, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

Assignees
No one assigned
Labels
feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
No open projects
8.2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new OnPropertyNameChanging and Changed overloads with old values
2 participants
@Sergio0694 @Youssef1313