Skip to content

Conversation

@Youssef1313
Copy link
Contributor

@Youssef1313 Youssef1313 commented Dec 10, 2024

Closes #<ISSUE_NUMBER>

Ensures that replacing sizeof(T) by Marshal.SizeOf<T>() will cause test failures ;)

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

@Sergio0694 Sergio0694 merged commit 78348ca into CommunityToolkit:main Dec 11, 2024
3 checks passed
@Youssef1313 Youssef1313 deleted the test-cov-indexof branch December 11, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants