🚧 Update/Test building of WinUI branch

[michael-hawker]

The winui branch of our repo hasn't been built since last fall. This PR is the initial work to test that we can build the pipeline again to produce a hotfix release before we work to merge our forks together on top of our new infrastructure from labs where all this can be coordinated together.

PR Type

What kind of change does this PR introduce?

• Refactoring (no functional changes, no api changes)

What is the current behavior?

Doesn't build

What is the new behavior?

Builds?

PR Checklist

Please check if your PR fulfills the following requirements:

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• Tested code with current supported SDKs
• New component
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • If control, added to Visual Studio Design project
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

Current Updates:

• Renewed UI Test app pfx cert
• Tested TAEF on commandline
  • MSTest not working in VS yet (not sure if was before)
• Changed PublishReadyToRun setting for .NET 6 to False
• Updated to 8.0 packages of .NET Community Toolkit
• see if runs in devops
• Update to WindowsAppSDK 1.1.x? There are some fundamental issues with us doing this, so we may stay on 1.0.x for hotfix
• Update test package versions (I tried but that caused issues)
• Update TAEF package version (there's new versions of this, but haven't gotten new feed location yet)
• Separate PR? Change min version down to 17763 - this requires our dependencies to update though

[ghost]

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[michael-hawker]

Need to retest WinUI pipeline and see if we were affected by the same environment issue as Color Code (see CommunityToolkit/ColorCode-Universal#28). Did find that cake may be the thing effected, easy enough to try and remove in Color Code; not so much here yet that's our 8.0 plan.

[michael-hawker]

Hmm, looks like it built but the test process failed... didn't see anything obvious or helpful in the output, hmm...

[michael-hawker]

Looks like it didn't run the Notifications tests (last week and this week):

2022-10-27T16:35:09.2552077Z vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.

2022-10-27T16:36:10.8578667Z �[41m�[37;1mAn error occurred when executing task '�[0m�[41;1m�[37;1mTest�[0m�[41m�[37;1m'.�[0m
2022-10-27T16:36:10.8691179Z �[41m�[37;1mError: �[0m�[41;1m�[37;1mOne or more errors occurred.�[0m
2022-10-27T16:36:10.8692888Z �[41m�[37;1m	�[0m�[41;1m�[37;1mVSTest: Process returned an error (exit code 1).�[0m
2022-10-27T16:36:11.0079870Z ##[error]PowerShell exited with code '1'.

[michael-hawker]

Seeing this NuGet error on the Notifications project locally, but not sure what it means:

h:\code\WindowsCommunityToolkit-WinUI\CommunityToolkit.WinUI.Notifications\CommunityToolkit.WinUI.Notifications.cs
proj : error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.

[Nirmal4G]

It means that some of the targets required for Restore are not found. But that is not usually the case. It might be due to the project file or related imports getting corrupted leading to subsequent imports not importing.

[michael-hawker]

@Nirmal4G this built in the CI before last month, so something externally has changed. I thought I had built locally as well, but it's failing as well there. Getting all sorts of bizarre NuGet issues.

Like it's even trying to pull in some old version of the SDK:

37>C:\Users\...\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\build\Microsoft.WinUI.AppX.targets(124,3): error MSB4019: The imported project "C:\Users\...\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\build\WinUI3-NET5-Projects-Dont-Use-MsAppxPackageTargets" was not found. Confirm that the expression in the Import declaration "WinUI3-NET5-Projects-Dont-Use-MsAppxPackageTargets" is correct, and that the file exists on disk.

The other maybe root error is also:

39>    C:\Program Files\dotnet\sdk\6.0.402\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(267,5): error NETSDK1004: Assets file 'H:\code\WindowsCommunityToolkit-WinUI\UITests\UITests.App\obj\wappublish\win10-x86\project.assets.json' not found. Run a NuGet package restore to generate this file.

NuGet restore is what gave me the error above about the _GetRestoreSettingsPerFramework.

FYI @azchohfi if you have any thoughts?

[azchohfi]

Wow... No, sorry, this is new to me.

[michael-hawker]

Tried running the build script locally and got this lovely message:

Very bizarre... wonder what .NET it's looking for:

h:\code\WindowsCommunityToolkit-WinUI>dotnet --list-sdks
3.1.424 [C:\Program Files\dotnet\sdk]
5.0.413 [C:\Program Files\dotnet\sdk]
6.0.202 [C:\Program Files\dotnet\sdk]
6.0.305 [C:\Program Files\dotnet\sdk]
6.0.402 [C:\Program Files\dotnet\sdk]

h:\code\WindowsCommunityToolkit-WinUI>dotnet --list-runtimes
Microsoft.AspNetCore.App 3.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.30 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.30 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]