#3794 Mirror #3832
Closed
#3794 Mirror #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a basic trailing whitespace clean-up, no formatting changes. Also, Removing common files in the 'Layout.Design' project that were duplicated.
- Remove 'AssemblyInfo.cs' as it is generated by the .NET SDK. - Move 'MetadataRegistration.cs' into Common folder so that it can be shared across Design projects along with others. - Update Solution to Use CPS for the Design projects.
The reason we build the Controls library first is that we have a dependency on the XML Doc file it generates. The Doc file is embedded within the Design library and it uses it's type-info to populate metadata automatically.
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
the
|
It's in draft, that's why I didn't enable edit. Otherwise, I might force push without looking. I currently stuck on CodeGen issue. Might take a while but I'll atleast push what I done already. |
|
Thanks @Nirmal4G we just wanted to test it on the latest. Will close this for now that you've updated the original. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3794
Not letting me update #3794, think Allow edit from maintainers is off. Test PR NuGet packages also rolled off back of our feed.
Updating to latest main and testing in latest VS to see how it compares to current main branch and which is better for 7.0 shipping.
FYI @Nirmal4G