Skip to content

Conversation

@andrewleader
Copy link
Contributor

@andrewleader andrewleader commented Jan 28, 2021

Fixes #3093

Fixing niche case where UWP devs modified their Default.rd.xml causing the library to not work in .NET Native. Thanks to https://github.com/OfficeDev/Open-XML-SDK/pull/241/files used that as reference!

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

See issue

What is the new behavior?

It works!

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jan 28, 2021

Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jan 28, 2021
Since those use the winmd version, need to include there too
@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Jan 28, 2021
@ghost
Copy link

ghost commented Feb 4, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 75c8719 into master Feb 5, 2021
@ghost ghost deleted the aleader/notif-net-native-fix branch February 5, 2021 00:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Toolkit.Uwp.Notifications.dll needs to be included in .NET Native runtime directives

4 participants