Skip to content

Conversation

@vgromfeld
Copy link
Contributor

@vgromfeld vgromfeld commented Apr 21, 2020

It follows #3201 and add some extensions methods to simplify the operations on ObservableGroupedCollection<TKey, TValue>.

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

This PR adds a set of extensions methods to simplify the add/insert/replace/remove operations on ObservableGroupedCollection<TKey, TValue>.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • If new feature, add to Feature List
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Apr 21, 2020

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned azchohfi Apr 21, 2020
@vgromfeld vgromfeld force-pushed the observableGroupExtensions branch from 48a93cd to 3c8b72c Compare April 22, 2020 16:19
@Sergio0694
Copy link
Member

Awesome! 🎉

I also think I have some optimizations to throw on top of most of these extensions by leveraging the fact that the ObservableCollection<T> type is almost always using a List<T> internally, which implements a struct enumerator - we can use that to achieve a faster and allocation free implementation of these new LINQ-style extensions 🚀

Looking forward to this getting merged, then I'll create another PR with those new tweaks!

@vgromfeld vgromfeld requested a review from azchohfi April 29, 2020 08:57
@vgromfeld vgromfeld merged commit fdee9c6 into CommunityToolkit:master Apr 30, 2020
@vgromfeld vgromfeld deleted the observableGroupExtensions branch April 30, 2020 10:33
@Sergio0694 Sergio0694 mentioned this pull request Apr 30, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants