-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Let BaseObjectStorageHelper use custom JsonSerializerOptions #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let BaseObjectStorageHelper use custom JsonSerializerOptions #3181
Conversation
|
Thanks simop-msft for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Microsoft.Toolkit.Uwp/Helpers/ObjectStorage/BaseObjectStorageHelper.cs
Outdated
Show resolved
Hide resolved
a1e2126 to
deb22db
Compare
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
|
Updated PR, but forgot to add header to new file IObjectSerializer. I also think that Microsoft.Toolkit.Uwp.Helpers is not necessarily a good place for this interface. |
deb22db to
54a2080
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Fixes #3175
PR Type
What kind of change does this PR introduce?
What is the current behavior?
JsonConvert calls in BaseObjectStorageHelper always use default JsonSerializerSettings, and a caller cannot provide custom ones.
What is the new behavior?
A JsonSerializerSettings object can be provided to Local/RoamingObjectStorageHelper, and will then be used in all serialization and deserialization calls.
PR Checklist
Please check if your PR fulfills the following requirements:
Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesTests for the changes have been added (for bug fixes / features) (if applicable)