Fix sudden CI errors #609

Arlodotexe · 2025-01-24T17:34:13Z

This PR

Fixes several errors related to missing XMLDoc comments.
Updates our uno.check version to the latest 1.27.4
Attempts unblock our CI

Prerequisite PR CommunityToolkit/Tooling-Windows-Submodule#249

michael-hawker · 2025-01-24T17:46:32Z

Hmm, looks like Uno-check isn't it...

"/home/runner/work/Windows/Windows/tooling/ProjectHeads/AllComponents/Wasm/CommunityToolkit.App.Wasm.csproj" (default target) (1:10) ->
(UnoGenerateAssetsManifest target) ->
/home/runner/.nuget/packages/uno.wasm.bootstrap/9.0.8/build/Uno.Wasm.Bootstrap.targets(270,3): error MSB4044: The "GenerateUnoAssetsManifest_v05da712db32bc85a0fb32e039ff4b1d24a10ddbb" task was not given a value for the required parameter "OutputPackagePath". [/home/runner/work/Windows/Windows/tooling/ProjectHeads/AllComponents/Wasm/CommunityToolkit.App.Wasm.csproj::TargetFramework=net9.0]

@jeromelaban did something else change this year we should be aware of?

This build on main passed at the end of 2024: https://github.com/CommunityToolkit/Windows/actions/runs/12550855416

And our next one with a simple typo fixed failed (and subsequent are failing): https://github.com/CommunityToolkit/Windows/actions/runs/12934722557

jeromelaban · 2025-01-24T18:22:19Z

@jeromelaban did something else change this year we should be aware of?

Yes, there is, it's a breaking changes for wasm in .NET 9.0.102 that we fixed with the uno.wasm.bootstrap 9.0.10, there's also a workaround in unoplatform/uno#19232 (comment) if you cannot update yet.

michael-hawker · 2025-01-24T19:16:25Z

Thanks Jerome! FYI @Arlodotexe - We should just be able to update the bootstrapper, eh? As we've moved to .NET 9?

Arlodotexe · 2025-01-24T19:30:07Z

Huge thanks @jeromelaban, I'll give that a go!

Thanks Jerome! FYI @Arlodotexe - We should just be able to update the bootstrapper, eh? As we've moved to .NET 9?

Notice how the other platforms are now failing after updating tooling. There are various "missing xml comment" error-warnings to resolve now, at least a dozen or two. Got that done locally, will push soon!

components/Primitives/src/SwitchPresenter/SwitchConverter.cs

components/Segmented/src/Segmented/Segmented.cs

michael-hawker

Think we can use inheritdoc in a few more places, but LGTM. Approving so we'll be unblocked once we get a clean CI and merge the submodule in before. Thanks!

michael-hawker · 2025-01-24T21:45:33Z

Looks like still have some XML clean-up. Not sure how we weren't catching that before. We've had that check on in the past.

Arlodotexe · 2025-01-24T22:02:05Z

Looks like still have some XML clean-up. Not sure how we weren't catching that before. We've had that check on in the past.

I'd been building wasm locally to test and made sure to build all multitargets, but hadn't thought to build all heads. Should be easy to fix...

Arlodotexe · 2025-01-24T22:03:00Z

The error that's appearing on UWP:

       "V:\Windows\tooling\ProjectHeads\AllComponents\uwp\CommunityToolkit.App.Uwp.csproj" (Clean;Build target) (1:7) ->
       "V:\Windows\components\SettingsControls\samples\SettingsControls.Samples.csproj" (default target) (5:25) ->
       "V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj" (default target) (7:32) ->
       (CoreCompile target) ->
         V:\Windows\components\Extensions\src\ListViewBase\ListViewExtensions.Command.cs(20,29): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also m 
       atched other overloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ListViewBase\ListViewExtensions.Command.cs(22,91): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also m 
       atched other overloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ListViewBase\ListViewExtensions.Command.cs(23,33): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also m 
       atched other overloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ListViewBase\ListViewExtensions.Command.cs(30,29): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also m 
       atched other overloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ListViewBase\ListViewExtensions.Command.cs(32,86): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also m 
       atched other overloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ListViewBase\ListViewExtensions.Command.cs(33,44): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also m 
       atched other overloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Markup\BitmapIconExtension.cs(14,37): error CS0419: Ambiguous reference in cref attribute: 'Uri'. Assuming 'Uri', but could have also matched other overloads  
       including 'Uri'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Markup\BitmapIconSourceExtension.cs(14,37): error CS0419: Ambiguous reference in cref attribute: 'Uri'. Assuming 'Uri', but could have also matched other over 
       loads including 'Uri'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(13,76): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(18,76): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(23,29): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(25,95): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(26,33): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(33,29): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(35,90): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(36,44): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(43,29): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(45,95): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(46,33): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(53,29): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(55,90): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\ScrollViewer\ScrollViewerExtensions.Properties.cs(56,44): error CS0419: Ambiguous reference in cref attribute: 'Thickness'. Assuming 'Thickness', but could ha 
       ve also matched other overloads including 'Thickness'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(19,31): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(24,77): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(34,29): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(36,99): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(37,33): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(41,29): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(43,84): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]
         V:\Windows\components\Extensions\src\Text\HyperlinkExtensions.cs(44,44): error CS0419: Ambiguous reference in cref attribute: 'ICommand'. Assuming 'ICommand', but could have also matched other ov 
       erloads including 'ICommand'. [V:\Windows\components\Extensions\src\CommunityToolkit.WinUI.Extensions.csproj::TargetFramework=uap10.0.17763]

Very strange that these are only appearing now. Does the platform even ship with generic versions of ICommand and Thickness?

Arlodotexe · 2025-01-24T22:10:13Z

Possibly related: dotnet/roslyn#51013

Arlodotexe · 2025-01-24T22:24:13Z

@michael-hawker We're thinking this may be caused by CommunityToolkit/Tooling-Windows-Submodule#245

Since this is clearly a platform bug, we'll suppress this for now.

…File

Bump uno.check version to 1.27.4

5dadc64

Arlodotexe added 3 commits January 24, 2025 13:34

Added missing XML doc comments

847185f

Update tooling pointer

98bdafe

Update test runner invocation to target .NET 8.0

869a9c1

michael-hawker reviewed Jan 24, 2025

View reviewed changes

components/Primitives/src/SwitchPresenter/SwitchConverter.cs Outdated Show resolved Hide resolved

michael-hawker reviewed Jan 24, 2025

View reviewed changes

components/Segmented/src/Segmented/Segmented.cs Outdated Show resolved Hide resolved

Refactor XML documentation to use <inheritdoc/> for inherited members

5b8b2b3

michael-hawker approved these changes Jan 24, 2025

View reviewed changes

Refactor XML documentation to use <inheritdoc/> for overridden members

6648706

Arlodotexe changed the title ~~Bump uno.check version to 1.27.4~~ Fix sudden CI errors Jan 24, 2025

Arlodotexe added 5 commits January 24, 2025 16:29

Workaround for unexpected CS0419 after enabling GenerateDocumentation…

4dd8013

…File

Workaround for unexpected CS1570 after enabling GenerateDocumentation…

0a7618c

…File

Workaround for unexpected CS1574 after enabling GenerateDocumentation…

0d3c7fe

…File

Use <inheritdoc/> where needed

dab0df0

Update tooling pointer to latest main

71cf576

Arlodotexe enabled auto-merge (rebase) January 25, 2025 01:58

Arlodotexe merged commit 9756f80 into main Jan 27, 2025
24 checks passed

michael-hawker deleted the uno-check/update branch January 28, 2025 00:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sudden CI errors #609

Fix sudden CI errors #609

Arlodotexe commented Jan 24, 2025 •

edited

Loading

michael-hawker commented Jan 24, 2025

jeromelaban commented Jan 24, 2025

michael-hawker commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025

michael-hawker left a comment

michael-hawker commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025 •

edited

Loading

Arlodotexe commented Jan 24, 2025 •

edited

Loading

Arlodotexe commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025

Fix sudden CI errors #609

Fix sudden CI errors #609

Conversation

Arlodotexe commented Jan 24, 2025 • edited Loading

michael-hawker commented Jan 24, 2025

jeromelaban commented Jan 24, 2025

michael-hawker commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025

michael-hawker left a comment

Choose a reason for hiding this comment

michael-hawker commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025 • edited Loading

Arlodotexe commented Jan 24, 2025 • edited Loading

Arlodotexe commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025

Arlodotexe commented Jan 24, 2025 •

edited

Loading

Arlodotexe commented Jan 24, 2025 •

edited

Loading

Arlodotexe commented Jan 24, 2025 •

edited

Loading