Fix solution generation via default .bat #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e uwp, wasdk, and wasm
michael-hawker
approved these changes
Dec 6, 2024
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
LGTM, want to open the tracking issue for resolving this long-term and link to from here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes solution generation issues when end users open the default
GenerateAllSolution.batby only enabling the default minimum MultiTargets (uwp, wasdk, wasm).The underlying issue affects solution generation when
android,iosormacosMultiTargets are requested or enabled. These targets don't have corresponding gallery or test heads that can be built, so they're unnecessary and have been disabled. This does not affect our ability to build these targets in CI.Issue also reported in the Windows App Community Discord.