Skip to content

Conversation

@Sergio0694
Copy link
Member

PR Type

What kind of change does this PR introduce?

This PR adds AcrylicBrush on WinUI 3 again. On this target, the BackgroundSource property has been removed.

What is the current behavior?

This type is missing for WinUI 3.

What is the new behavior?

The type is usable again.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added the enhancement New feature or request label Aug 24, 2024
@Sergio0694 Sergio0694 requested a review from Arlodotexe August 24, 2024 19:23
@Arlodotexe Arlodotexe merged commit 0b81fca into main Aug 24, 2024
@Arlodotexe Arlodotexe deleted the sergiopedri/acrylic-brush-winui3 branch August 24, 2024 22:48
@michael-hawker
Copy link
Member

Future note, as I know this came up elsewhere when we were porting some Media samples, is since the property only exists on WinUI2, it makes it harder to share XAML across both platforms. It'd be nicer if the property existed for WinUI3 even if it was a no-op or always set to one value.

It's a general issue, but something we should be cognizant of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants