Skip to content

Conversation

@ajpinedam
Copy link
Contributor

Fixes

PR Type

What kind of change does this PR introduce?

Code style update (formatting)

What is the current behavior?

The summary in SettingsCard was pointing to the wrong types.

What is the new behavior?

Use the correct type based on the Property Name.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • Contains NO breaking changes

Other information

Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

@Arlodotexe Arlodotexe enabled auto-merge (squash) August 12, 2024 17:00
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajpinedam, we have many of these copy-paste issues I'm sure! 😋

@michael-hawker michael-hawker enabled auto-merge (rebase) August 14, 2024 19:07
@michael-hawker michael-hawker force-pushed the chore/fix.typos.properties.info branch from 786c713 to 7d0b4ea Compare October 31, 2024 15:43
@michael-hawker michael-hawker merged commit 7ab8a42 into CommunityToolkit:main Oct 31, 2024
23 checks passed
@ajpinedam ajpinedam deleted the chore/fix.typos.properties.info branch November 1, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants