Cleanup of WindowsAppSDK implicit properties and project references #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft.Windows.CsWinRT and Microsoft.Windows.SDK.BuildTools. See #217 (comment) and #217 (comment).
Member
Author
|
Note that while the tooling repo has been updated to 8.0.403, the https://github.com/CommunityToolkit/Windows and https://github.com/CommunityToolkit/Labs-Windows repos are still using 8.0.201. This will need to be updated when those repos consume this tooling change. |
michael-hawker
approved these changes
Oct 25, 2024
Sergio0694
approved these changes
Oct 25, 2024
Arlodotexe
deleted the
cleanup/wasdk/explicit-props-and-packagereferences
branch
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up unnecessary explicit declaration of
Microsoft.Windows.SDK.BuildTools, as the same version comes fromMicrosoft.WindowsAppSdkvia a transitive nuget reference.Microsoft.Windows.CsWinRT, since the CsWinRT analyzers and .dll are inside the runtime pack for the Windows SDK.WindowsSdkPackageVersion, since this is set automatically by the underlying SDK when running dotnet 8.0.403 or later.Follow up to #217 (comment) and #217 (comment), closes #219.