Add `SemaphoreSlim` Support for `Popup` `CloseAsync` to Avoid Race Conditions#3235

Merged

TheCodeTraveler merged 28 commits into

mainfrom

Ensure-Popup-Has-Closed-Before-`CloseAsync`-Returns

Jun 9, 2026

Commits on Jun 6, 2026

Subscribe to `ModalPopped`
TheCodeTraveler
committed
Call `GetParentWindow()` inside `CloseAsync`
TheCodeTraveler
committed
Add Test Timeouts
TheCodeTraveler
committed
Update PopupPageTests.cs
TheCodeTraveler
committed
Add `popup.NotifyPopupIsClosed();`
TheCodeTraveler
committed
Update PopupPageTests.cs
TheCodeTraveler
committed
Add support for nested Popups
TheCodeTraveler
committed
Add missing unit tests
TheCodeTraveler
committed
Update PopupPage.shared.cs
TheCodeTraveler
committed
Update PopupPageTests.cs
TheCodeTraveler
committed
Update PopupPage.shared.cs
TheCodeTraveler
committed
Add PopupPage.ShowAsync
TheCodeTraveler
committed
Add Missing Unit Tests
TheCodeTraveler
committed
In `CloseAsync`, implement `navigationSemaphoreSlim` inside its own try/finally block
TheCodeTraveler
committed
Add missing unit tests
TheCodeTraveler
committed
Fix null referece
TheCodeTraveler
committed
Update SemaphoreSlim(1,1) logic in CloseAsync
TheCodeTraveler
committed
`dotnet format`
TheCodeTraveler
committed
Potential fix for pull request finding

TheCodeTraveler
and
Copilot
authored
Potential fix for pull request finding

TheCodeTraveler
and
Copilot
authored
await SemaphoreSlim(1,1) inside try/finally to ensure event deregistration
TheCodeTraveler
committed
Potential fix for pull request finding

TheCodeTraveler
and
Copilot
authored
Update logic for navigationSemaphoreSlim.Release
TheCodeTraveler
committed
Merge branch 'Ensure-Popup-Has-Closed-Before-`CloseAsync`-Returns' of https://github.com/CommunityToolkit/Maui into Ensure-Popup-Has-Closed-Before-`CloseAsync`-Returns
TheCodeTraveler
committed
Fix XML error
TheCodeTraveler
committed
Remove `WaitAsync`
TheCodeTraveler
committed
Potential fix for pull request finding

TheCodeTraveler
and
Copilot
authored
Potential fix for pull request finding

TheCodeTraveler
and
Copilot
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `SemaphoreSlim` Support for `Popup` `CloseAsync` to Avoid Race Conditions#3235

Add `SemaphoreSlim` Support for `Popup` `CloseAsync` to Avoid Race Conditions#3235
TheCodeTraveler merged 28 commits into
mainfrom
Ensure-Popup-Has-Closed-Before-`CloseAsync`-Returns

Commits on Jun 6, 2026

Subscribe to `ModalPopped`

Call `GetParentWindow()` inside `CloseAsync`

Add Test Timeouts

Update PopupPageTests.cs

Add `popup.NotifyPopupIsClosed();`

Update PopupPageTests.cs

Add support for nested Popups

Add missing unit tests

Update PopupPage.shared.cs

Update PopupPageTests.cs

Update PopupPage.shared.cs

Add PopupPage.ShowAsync

Add Missing Unit Tests

In `CloseAsync`, implement `navigationSemaphoreSlim` inside its own try/finally block

Add missing unit tests

Fix null referece

Update SemaphoreSlim(1,1) logic in CloseAsync

`dotnet format`

Potential fix for pull request finding

Potential fix for pull request finding

await SemaphoreSlim(1,1) inside try/finally to ensure event deregistration

Potential fix for pull request finding

Update logic for navigationSemaphoreSlim.Release

Merge branch 'Ensure-Popup-Has-Closed-Before-`CloseAsync`-Returns' of https://github.com/CommunityToolkit/Maui into Ensure-Popup-Has-Closed-Before-`CloseAsync`-Returns

Fix XML error

Remove `WaitAsync`

Potential fix for pull request finding

Potential fix for pull request finding