Add Support for StatusBarBehavior in Android Modal Page
#3123
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,57 +35,58 @@ static void PlatformSetColor(Color color) | |
| return; | ||
| } | ||
|
|
||
| if (GetCurrentWindow() is not Window { DecorView.RootView: not null } window) | ||
| { | ||
| return; | ||
| } | ||
|
TheCodeTraveler marked this conversation as resolved.
|
||
|
|
||
| var platformColor = color.ToPlatform(); | ||
|
|
||
| if (OperatingSystem.IsAndroidVersionAtLeast(35)) | ||
| { | ||
| const string statusBarOverlayTag = "StatusBarOverlay"; | ||
|
|
||
| var decorGroup = (ViewGroup)window.DecorView.RootView; | ||
|
TheCodeTraveler marked this conversation as resolved.
|
||
| var statusBarOverlay = decorGroup.FindViewWithTag(statusBarOverlayTag); | ||
|
TheCodeTraveler marked this conversation as resolved.
|
||
|
|
||
| if (statusBarOverlay is null) | ||
| { | ||
| var statusBarHeight = Activity.Resources?.GetIdentifier("status_bar_height", "dimen", "android") ?? 0; | ||
| var statusBarPixelSize = statusBarHeight > 0 ? Activity.Resources?.GetDimensionPixelSize(statusBarHeight) ?? 0 : 0; | ||
|
|
||
| statusBarOverlay = new(Activity) | ||
| { | ||
| LayoutParameters = new FrameLayout.LayoutParams(Android.Views.ViewGroup.LayoutParams.MatchParent, statusBarPixelSize + 3) | ||
| { | ||
| Gravity = GravityFlags.Top | ||
| } | ||
| }; | ||
|
|
||
|
TheCodeTraveler marked this conversation as resolved.
|
||
| statusBarOverlay.Tag = statusBarOverlayTag; | ||
| decorGroup.AddView(statusBarOverlay); | ||
| statusBarOverlay.SetZ(0); | ||
| } | ||
|
|
||
| statusBarOverlay.SetBackgroundColor(platformColor); | ||
| } | ||
| else | ||
| { | ||
| window.SetStatusBarColor(platformColor); | ||
| } | ||
|
|
||
| bool isColorTransparent = platformColor == PlatformColor.Transparent; | ||
| if (isColorTransparent) | ||
| { | ||
| window.ClearFlags(WindowManagerFlags.DrawsSystemBarBackgrounds); | ||
|
Member
There was a problem hiding this comment. I don't know any other way to deal with issue of status bar transparency but settings and clearing flags can and will interfere with developers attempts to set or use full screen and in a test app I had to remove all the settings and clearing of flags to have my app do what I wanted. I removed it throughout the toolkit where I found it in statusbar. I am not sure what we should do here. This is more a comment about the current state of the behavior of hiding/showing status bar is a complicated mess atm and depending on API level settings these options will have completely different behavior on each API. I do not advocate ripping out the flags I am simply stating all of my use cases do require it. It would have significant impact on all API below 36 so I am not suggesting we do that. Just maybe add checks and block the changes for android 36? There was a problem hiding this comment. It might be a good idea to add full-screen mode to CommunityToolkit.Maui so it doesn't interfere with the color change. We could also use an IsVisible boolean on the status bar and navigation bar.
Collaborator
Author
There was a problem hiding this comment. @IgrisModz sure! What specifically do we need to add? Do you have any links to documentation you could share? |
||
| window.SetFlags(WindowManagerFlags.LayoutNoLimits, WindowManagerFlags.LayoutNoLimits); | ||
| } | ||
| else | ||
| { | ||
| window.ClearFlags(WindowManagerFlags.LayoutNoLimits); | ||
| window.SetFlags(WindowManagerFlags.DrawsSystemBarBackgrounds, WindowManagerFlags.DrawsSystemBarBackgrounds); | ||
| } | ||
|
|
||
| WindowCompat.SetDecorFitsSystemWindows(window, !isColorTransparent); | ||
|
Member
There was a problem hiding this comment. This method is deprecated on Android API 36. It is highly recommended that we add a check and only use it on an OS using a lower API. |
||
| } | ||
|
|
||
| static void PlatformSetStyle(StatusBarStyle style) | ||
|
|
@@ -98,25 +99,32 @@ static void PlatformSetStyle(StatusBarStyle style) | |
| switch (style) | ||
| { | ||
| case StatusBarStyle.DarkContent: | ||
| SetStatusBarAppearance(true); | ||
| break; | ||
|
|
||
| case StatusBarStyle.Default: | ||
| case StatusBarStyle.LightContent: | ||
| SetStatusBarAppearance(false); | ||
| break; | ||
|
|
||
| default: | ||
| throw new NotSupportedException($"{nameof(StatusBarStyle)} {style} is not yet supported on Android"); | ||
| } | ||
| } | ||
|
|
||
| static void SetStatusBarAppearance(bool isLightStatusBars) | ||
| { | ||
| if(GetCurrentWindow() is Window window | ||
|
TheCodeTraveler marked this conversation as resolved.
Outdated
|
||
| && WindowCompat.GetInsetsController(window, window.DecorView) is WindowInsetsControllerCompat windowController) | ||
| { | ||
| windowController.AppearanceLightStatusBars = isLightStatusBars; | ||
| } | ||
| } | ||
|
|
||
| // Check if a modal DialogFragment is active and use its window | ||
| static Window? GetCurrentWindow() | ||
| { | ||
| var dialogFragment = Activity.GetFragmentManager()?.Fragments.OfType<AndroidX.Fragment.App.DialogFragment>().LastOrDefault(); | ||
| return dialogFragment?.Dialog?.Window ?? Activity.Window; // Fall back to the Activity window for non-modal pages | ||
|
TheCodeTraveler marked this conversation as resolved.
Outdated
TheCodeTraveler marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.