Fix duplicate state container view states by TheCodeTraveler · Pull Request #3095 · CommunityToolkit/Maui

TheCodeTraveler · 2026-02-13T22:30:10Z

Description of Change

This PR removes the public static IList<View> that was being used for the DefaultValueCreator of the StateContainer.StateViews Attached Property, replacing it with a simple instance of a new collection, [].

This fixes a bug where, where this static IList<View> was being reused for every StateView for every StateContainer.

Linked Issues

Fixes [BUG] StateContainer broken / same view is displayed all the time on Version 14.0.0 #3068

PR Checklist

Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard

Additional information

Copilot

Pull request overview

This PR addresses a StateContainer bug where the default StateViews collection was shared across layouts, causing state views to bleed between different StateContainer usages (issue #3068).

Changes:

Removed the static default StateViews collection from StateContainerDefaults.
Updated the StateViews attached property default value creator to return a new empty collection per layout.
Adjusted StateContainerController initialization and updated unit tests accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/CommunityToolkit.Maui/Primitives/StateContainerDefaults.shared.cs	Removes the shared static default `StateViews` collection.
src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs	Refactors controller construction and changes `StateViews` to `IReadOnlyList` with `init`.
src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainer.shared.cs	Uses a new empty collection as the default `StateViews` value; controller creation now copies `StateViews`.
src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs	Updates tests for the new `StateViews` behavior and adds a new uniqueness test.

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainer.shared.cs

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs

src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs

…r.shared.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rController.shared.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs

src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs

…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs

src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs

…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rController.shared.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

TheCodeTraveler · 2026-02-13T23:31:57Z

Thanks @bijington! Could you give it one more quick review now that I implemented some of CoPilot's suggestions?

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

bijington

LGTM!

TheCodeTraveler added 2 commits February 13, 2026 14:00

Remove static default value for StateContainer.StateViews

6741545

Update StateContainerTests.cs

f4e2582

TheCodeTraveler requested review from VladislavAntonyuk and Copilot February 13, 2026 22:30

Copilot started reviewing on behalf of TheCodeTraveler February 13, 2026 22:30 View session

bijington previously approved these changes Feb 13, 2026

View reviewed changes

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Update Unit Tests

5f4bf2d

TheCodeTraveler dismissed bijington’s stale review via 5f4bf2d February 13, 2026 23:05

TheCodeTraveler requested a review from Copilot February 13, 2026 23:09

Copilot started reviewing on behalf of TheCodeTraveler February 13, 2026 23:10 View session

TheCodeTraveler and others added 3 commits February 13, 2026 15:10

Update src/CommunityToolkit.Maui/Layouts/StateContainer/StateContaine…

1334b54

…r.shared.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/CommunityToolkit.Maui/Layouts/StateContainer/StateContaine…

909be70

…rController.shared.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update StateContainerTests.cs

7224db9

Copilot AI reviewed Feb 13, 2026

View reviewed changes

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs Outdated Show resolved Hide resolved

src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs Outdated Show resolved Hide resolved

Update src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTest…

490d82e

…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 13, 2026 23:17

Copilot started reviewing on behalf of TheCodeTraveler February 13, 2026 23:18 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs Show resolved Hide resolved

Add InnerException to StateConainerException

9592b21

TheCodeTraveler requested a review from Copilot February 13, 2026 23:26

Copilot started reviewing on behalf of TheCodeTraveler February 13, 2026 23:26 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

src/CommunityToolkit.Maui/Layouts/StateContainer/StateContainerController.shared.cs Outdated Show resolved Hide resolved

src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs Outdated Show resolved Hide resolved

Update src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTest…

155ed85

…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 13, 2026 23:30

Copilot started reviewing on behalf of TheCodeTraveler February 13, 2026 23:31 View session

Update src/CommunityToolkit.Maui/Layouts/StateContainer/StateContaine…

706bfdc

…rController.shared.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

TheCodeTraveler enabled auto-merge (squash) February 13, 2026 23:32

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Update StateContainerTests.cs

65f5189

bijington approved these changes Feb 14, 2026

View reviewed changes

TheCodeTraveler merged commit 251d61a into main Feb 14, 2026
10 checks passed

TheCodeTraveler deleted the Fix-Duplicate-StateContainer-ViewStates branch February 14, 2026 08:33

TheCodeTraveler mentioned this pull request Feb 14, 2026

Add BindablePropertyDefaultValueCreatorAnalyzer to to avoid Static References from being passed into CreateDefaultValueMethodName when using [BindableProperty] and [AttachedBindableProperty<T>]. #3096

Open

5 tasks

github-actions bot locked and limited conversation to collaborators Feb 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix duplicate state container view states#3095

Fix duplicate state container view states#3095
TheCodeTraveler merged 11 commits intomainfrom
Fix-Duplicate-StateContainer-ViewStates

TheCodeTraveler commented Feb 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

TheCodeTraveler commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

bijington left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TheCodeTraveler commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Linked Issues

PR Checklist

Additional information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

TheCodeTraveler commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bijington left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TheCodeTraveler commented Feb 13, 2026 •

edited

Loading