Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR downgrades the Windows App SDK dependency used by CommunityToolkit.Maui.Core and adjusts the Windows FolderPicker implementation to compile against the downgraded API surface.
Changes:
- Downgrade
Microsoft.WindowsAppSDKpackage reference inCommunityToolkit.Maui.Core. - Remove (comment out) use of
FolderPicker.SuggestedFolderin the Windows FolderPicker implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/CommunityToolkit.Maui.Core/Essentials/FolderPicker/FolderPickerImplementation.windows.cs |
Stops setting SuggestedFolder (now commented), which changes Windows behavior for initialPath. |
src/CommunityToolkit.Maui.Core/CommunityToolkit.Maui.Core.csproj |
Downgrades the Windows App SDK NuGet package reference. |
src/CommunityToolkit.Maui.Core/Essentials/FolderPicker/FolderPickerImplementation.windows.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information