Fix memory leak on popups #2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `PopupPage` constructor to use a separate `TapOutsideCommand` method for handling taps outside the popup, enhancing code readability and maintainability. The new method encapsulates the tap logic and ensures proper closure of the popup. Additionally, cleared gesture recognizers on navigation away to prevent unintended interactions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leak just happens if the Popup is singleton, the
PropertyChangedandpageTapGestureRecognizer.Tappedevent subscriptions will hold a strong reference between those elements and cause a memory leak. Making sure to unhold from references will solve the leak.PopupPageLayoutwill take longer to be released, not sure why but even with that there's no leak.Fixes: #2855