Skip to content

Prevent Popup From Being Dismissed when Tapped Inside Popup #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 7 commits into from
Jul 11, 2025
Merged

Prevent Popup From Being Dismissed when Tapped Inside Popup #2800

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9477a7c
Workaround .NET MAUI touch based behaviour
bijington Jul 8, 2025
10f0222
Shift to checking the bounds of the touch
bijington Jul 10, 2025
51e996b
Refactor code
TheCodeTraveler Jul 11, 2025
2a83448
Update Unit Tests
TheCodeTraveler Jul 11, 2025
32860e0
Update Unit Tests
TheCodeTraveler Jul 11, 2025
d7538d2
`dotnet format`
TheCodeTraveler Jul 11, 2025
7e7636d
Merge branch 'main' into feature/sl-patch-tap-gesture
TheCodeTraveler Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ public PopupPageLayout(in Popup popupContent, in IPopupOptions options, in IComm
BackgroundColor = popupContent.BackgroundColor ??= Options.DefaultPopupSettings.BackgroundColor,
Content = popupContent
};

// Currently .NET MAUI allows for the TapGestureRecognizer added to the BoxView behind this Border to be triggered with a tap on Android.
PopupBorder.GestureRecognizers.Add(new TapGestureRecognizer());

// Bind `Popup` values through to Border using OneWay Bindings
PopupBorder.SetBinding(Border.MarginProperty, static (Popup popup) => popup.Margin, source: popupContent, mode: BindingMode.OneWay, converter: new MarginConverter());
Expand Down
Loading