[Popup] Add Popup.CanBeDismissedByTappingOutsideOfPopup#2753
Merged
TheCodeTraveler merged 4 commits intomainfrom Jun 20, 2025
Merged
[Popup] Add Popup.CanBeDismissedByTappingOutsideOfPopup#2753TheCodeTraveler merged 4 commits intomainfrom
Popup.CanBeDismissedByTappingOutsideOfPopup#2753TheCodeTraveler merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the bindable property CanBeDismissedByTappingOutsideOfPopup to the Popup control and updates dismissal logic so that a popup is only dismissed when both Popup.CanBeDismissedByTappingOutsideOfPopup and IPopupOptions.CanBeDismissedByTappingOutsideOfPopup are true. Key changes include:
- Adding the bindable property and XML documentation for CanBeDismissedByTappingOutsideOfPopup in Popup.shared.cs.
- Refactoring PopupPage.shared.cs to use a new helper method for evaluating the dismissal condition.
- Adding unit tests to verify the tap gesture recognizer behavior when the property values vary.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs | Updates to dismissal logic and event handlers using GetCanBeDismissedByTappingOutsideOfPopup. |
| src/CommunityToolkit.Maui/Views/Popup/Popup.shared.cs | New bindable property for CanBeDismissedByTappingOutsideOfPopup with XML documentation. |
| src/CommunityToolkit.Maui/Primitives/Defaults/PopupDefaults.shared.cs | Added default constant for CanBeDismissedByTappingOutsideOfPopup. |
| src/CommunityToolkit.Maui.UnitTests/Views/Popup/PopupPageTests.cs | New test verifying that the tap gesture recognizer respects both dismissal conditions. |
bijington
approved these changes
Jun 20, 2025
Contributor
bijington
left a comment
There was a problem hiding this comment.
Thanks @TheCodeTraveler I just added a comment to the copilot point regarding bitwise otherwise this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds the bindable property
public bool CanBeDismissedByTappingOutsideOfPopup { get; set }toPopup.This PR also updates the logic in
PopupPageto only dismiss a Popup when bothPopup.CanBeDismissedByTappingOutsideOfPopupandIPopupOptions.CanBeDismissedByTappingOutsideOfPopupare true:Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional Information
This feature allows developers to subclass from Popup and create a reusable Popup that cannot be dismissed when the user taps outside of Popup: