Remove exception swallowing and update tests to exhibit expected behaviour#2749
Merged
TheCodeTraveler merged 14 commits intomainfrom Jun 22, 2025
Merged
Remove exception swallowing and update tests to exhibit expected behaviour#2749TheCodeTraveler merged 14 commits intomainfrom
TheCodeTraveler merged 14 commits intomainfrom
Conversation
src/CommunityToolkit.Maui.UnitTests/Services/PopupServiceTests.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.UnitTests/Services/PopupServiceTests.cs
Outdated
Show resolved
Hide resolved
…unityToolkit/Maui into feature/sl-improve-popup-unit-tests
6 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the old AddPopup helper to avoid swallowed exceptions and modernizes the unit tests to use short- and long-lived popup classes that correctly close themselves. Key changes include:
- Deleted the legacy internal
AddPopupmethod fromPopupService.shared.cs. - Replaced all uses of
MockSelfClosingPopup/MockPageViewModelin tests withShortLivedSelfClosingPopup/ShortLivedMockPageViewModel(and related long-lived variants). - Introduced new test popup types with configurable durations, added GC calls in open/close handlers, and updated the mock dispatcher to block for delays.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui/Services/PopupService.shared.cs | Removed deprecated internal AddPopup method. |
| src/CommunityToolkit.Maui.UnitTests/Mocks/MockDispatcher.cs | Changed DispatchDelayed to use Thread.Sleep and return true. |
| src/CommunityToolkit.Maui.UnitTests/Layouts/StateContainerTests.cs | Switched to Assert.ThrowsAnyAsync for animation timeout tests. |
| src/CommunityToolkit.Maui.UnitTests/BaseHandlerTest.cs | Updated service registrations for the new popup/view-model types. |
TheCodeTraveler
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This doesn't technically fix any bugs but it does fix some inconsistencies in our unit tests. You may notice there are some
Console.Writelinestatements in this PR. What I have observed on occasion is thatClosingis logged butClosedis not which makes me wonder if it is close to potentially reproducing #2703Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information