Skip to content

Conversation

@pictos
Copy link
Member

@pictos pictos commented Mar 20, 2025

Description of Change

Linked Issues

PR Checklist

Additional information

@pictos pictos requested a review from a team March 20, 2025 15:08
Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's instead change void OnTextPropertyChanged to async void OnTextPropertyChanged and use async/await.

To be honest, I should've made this recommendation in the code review when this was originally implemented; the current implementation just attempts to recreate how Async/Await works under the hood, but does it in a less-efficient, less maintainable, manner than Async/Await.

@pictos pictos force-pushed the pj/forward-behavior-to-run-on-ui-thread branch from f76dea4 to 27030ba Compare March 20, 2025 16:14
Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro!

@TheCodeTraveler TheCodeTraveler changed the title Run continuation on UIThread Run UserStoppedTypingBehavior Command on UIThread Mar 21, 2025
@TheCodeTraveler TheCodeTraveler merged commit 3c5b069 into main Mar 21, 2025
10 checks passed
@TheCodeTraveler TheCodeTraveler deleted the pj/forward-behavior-to-run-on-ui-thread branch March 21, 2025 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] UserStoppedTypingBehavior Command does not run on the MainThread

3 participants