-
Notifications
You must be signed in to change notification settings - Fork 480
Run UserStoppedTypingBehavior Command on UIThread #2591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run UserStoppedTypingBehavior Command on UIThread #2591
Conversation
src/CommunityToolkit.Maui/Behaviors/UserStoppedTypingBehavior.shared.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's instead change void OnTextPropertyChanged to async void OnTextPropertyChanged and use async/await.
To be honest, I should've made this recommendation in the code review when this was originally implemented; the current implementation just attempts to recreate how Async/Await works under the hood, but does it in a less-efficient, less maintainable, manner than Async/Await.
f76dea4 to
27030ba
Compare
src/CommunityToolkit.Maui/Behaviors/UserStoppedTypingBehavior.shared.cs
Outdated
Show resolved
Hide resolved
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pedro!
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information