[Housekeeping] Add [SupportedOSPlatform] to AppBuilderExtensions#2488
Merged
TheCodeTraveler merged 4 commits intomainfrom Feb 3, 2025
Merged
Conversation
TheCodeTraveler
commented
Feb 3, 2025
src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs
Show resolved
Hide resolved
VladislavAntonyuk
approved these changes
Feb 3, 2025
ne0rrmatrix
approved these changes
Feb 3, 2025
Member
ne0rrmatrix
left a comment
There was a problem hiding this comment.
This is sweet! I am happy to see the build message about versions being put to rest for all those messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds the
[SupportedOSPlatform]attribute to eachAppBuilderExtensionsfile, declaring the minimum supported operating system version for each platform as supported by the .NET MAUI Community Toolkit(s).This ensures that users are warned immediately when using any
CommunityToolkit.Maui.*library that they may be targeting an unsupported version of iOS/Android/Windows/MacCatalyst/Tizen when initializing the toolkit. This PR follows the existing implementation set inCommunityToolkit.Maui.Camera.AppBuilderExtensions.It's basically an easy way for us to notify developers regrading which platforms we support without requiring them to read the Release Notes.
PR Checklist
mainat time of PRAdditional information
The version numbers align with the
SupportedOSPlatformVersionnoted in each library's csproj:Maui/src/CommunityToolkit.Maui/CommunityToolkit.Maui.csproj
Lines 21 to 26 in fa4004d
This PR also renames
CommunityToolkit.Maui.Maps.AppHostBuilderExtension->CommunityToolkit.Maui.Maps.AppBuilderExtensionto align with the naming used inCommunityToolkit.Maui,CommunityToolkit.Maui.Core,CommunityToolkit.Maui.MediaElementandCommunityToolkit.Maui.Camera.