Fix XamlRoot being set incorrectly in Popup Handler#2476
Merged
TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom Jan 29, 2025
Merged
Fix XamlRoot being set incorrectly in Popup Handler#2476TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom
TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom
Conversation
…navigation in Windows
…rge when testing Mulitple popups page
pictos
approved these changes
Jan 28, 2025
TheCodeTraveler
merged commit 2ac604e
into
CommunityToolkit:main
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes incorrect XamlRoot being set when application uses modal navigation and opens a popup. The current behavior results in application crashing. This sets the
XamlRootcorrectly and the app does not crash. Additionally made a cosmetic size change to sizing for large popup as it is too large and covers the whole window in some situations inMultiple Popups Page.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Currently the windows implementation of
Popuphas the xaml root set incorrectly. I updated theXamlRootin the handler for Popup to fix the issue. The linked issue has a CTD when using modal navigation and opening aPopup.